diff --git a/src/os/object/xdrinput.cc b/src/os/object/xdrinput.cc index 612244e95f327c84653a50d87ce2a5f2376810bf..e722fdd37d465f062dd006156ea18d3199acb910 100644 --- a/src/os/object/xdrinput.cc +++ b/src/os/object/xdrinput.cc @@ -41,6 +41,8 @@ float XDRInput::get_float() uint32_t i; float f; } v; + // Setting one member of a struct and then reading another is undefined + // behaviour, but works as intended in nearly any (embedded) compiler v.i = get_uint32(); return v.f; } @@ -51,6 +53,8 @@ double XDRInput::get_double() uint64_t i; double d; } v; + // Setting one member of a struct and then reading another is undefined + // behaviour, but works as intended in nearly any (embedded) compiler v.i = get_uint64(); return v.d; } diff --git a/src/os/object/xdrstream.cc b/src/os/object/xdrstream.cc index ad708be146cbc1886b802109e6c5a6dbd367afe9..f0c9365ae585b94e36c4efe8cfc39d6d1496deef 100644 --- a/src/os/object/xdrstream.cc +++ b/src/os/object/xdrstream.cc @@ -74,6 +74,8 @@ XDRStream & XDRStream::operator<<(float number) uint32_t i; float f; } v; + // Setting one member of a struct and then reading another is undefined + // behaviour, but works as intended in nearly any (embedded) compiler v.f = number; *this << v.i; return *this; @@ -85,6 +87,8 @@ XDRStream & XDRStream::operator<<(double number) uint64_t i; double d; } v; + // Setting one member of a struct and then reading another is undefined + // behaviour, but works as intended in nearly any (embedded) compiler v.d = number; *this << v.i; return *this;