Commit 23c0341c authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

Write errors to STDERR

parent aa509864

bin/efa

+9 −7
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ my $ignore_info = 'Fahrradmitnahme'; 
my ($test_dump, $test_parse);



binmode(STDOUT, ':utf8');

binmode(STDERR, ':utf8');



sub check_ambiguous {

	my ($full_tree) = @_;
@@ -36,13 +37,13 @@ sub check_ambiguous { 


	foreach my $select (@{$full_tree->findnodes($xp_select)}) {

		$ambiguous = 1;

		printf(

		printf {*STDERR} (

			"Ambiguous input for %s\n",

			$select->getAttribute('name'),

		);

		foreach my $val ($select->findnodes($xp_option)) {

			print "\t";

			say $val->textContent();

			print {*STDERR} "\t";

			say {*STDERR} $val->textContent();

		}

	}

	if ($ambiguous) {
@@ -59,10 +60,10 @@ sub check_no_connections { 
	my $err_node = $full_tree->findnodes($xp_err_img)->[0];



	if ($err_node) {

		say "Looks like efa.vrr.de showed an error.";

		say "I will now try to dump the error message:";

		say {*STDERR} "Looks like efa.vrr.de showed an error.";

		say {*STDERR} "I will now try to dump the error message:";



		say $err_node->parentNode()->parentNode()->textContent();

		say {*STDERR} $err_node->parentNode()->parentNode()->textContent();



		exit 2;

	}
@@ -268,7 +269,8 @@ sub parse_tree { 
		return $cons;

	}

	else {

		say "efa.vrr.de returned no connections, check your input data.";

		say {*STDERR}

			"efa.vrr.de returned no connections, check your input data.";

		exit 3;

	}

}

test/50-efa.t

+6 −6
Original line number Diff line number Diff line
@@ -142,21 +142,21 @@ $cmd = Test::Command->new( 
);



$cmd->exit_is_num(1);

$cmd->stdout_is_file('test/parse_ambiguous');

$cmd->stderr_is_eq($EMPTY);

$cmd->stdout_is_eq($EMPTY);

$cmd->stderr_is_file('test/parse_ambiguous');



$cmd = Test::Command->new(

	cmd => "$efa $test_parse < test/dump_no_connections"

);



$cmd->exit_is_num(2);

$cmd->stdout_is_file('test/parse_no_connections');

$cmd->stderr_is_eq($EMPTY);

$cmd->stdout_is_eq($EMPTY);

$cmd->stderr_is_file('test/parse_no_connections');



$cmd = Test::Command->new(

	cmd => "$efa $test_parse < test/dump_invalid_input"

);



$cmd->exit_is_num(3);

$cmd->stdout_is_file('test/parse_invalid_input');

$cmd->stderr_is_eq($EMPTY);
 
$cmd->stdout_is_eq($EMPTY);

$cmd->stderr_is_file('test/parse_invalid_input');