Commit cddc688b authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

Code cleanup

parent 17608f3e

bin/efa-m

+11 −19
Original line number Diff line number Diff line
@@ -75,15 +75,7 @@ sub display_result { 


for my $d ( $status->results ) {



	push(

		@output,

		[

			$d->time,

			$d->platform,

			$d->line,

			$d->destination,

		]

	);

	push( @output, [ $d->time, $d->platform, $d->line, $d->destination, ] );

}



display_result(@output);

lib/Travel/Status/DE/VRR.pm

+55 −50
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ use 5.010; 


our $VERSION = '0.00';



use Carp qw(confess);

use Travel::Status::DE::VRR::Result;

use WWW::Mechanize;

use XML::LibXML;
@@ -54,7 +55,7 @@ sub new { 
	$mech->post( 'http://efa.vrr.de/vrr/XSLT_DM_REQUEST', $self->{post} );



	if ( $mech->response->is_error ) {

		die( $mech->response->status_line );

		confess( $mech->response->status_line );

	}



	my $form = $mech->form_number(1);
@@ -66,7 +67,7 @@ sub new { 
	$mech->click('submitButton');



	if ( $mech->response->is_error ) {

		die( $mech->response->status_line );

		confess( $mech->response->status_line );

	}



	$self->{html} = $mech->response->decoded_content;
@@ -99,13 +100,17 @@ sub results { 
	  @parts;



	for my $tr ( $self->{tree}->findnodes($xp_element) ) {

		my ($time, $platform, $line, $dest) = map { ($tr->findnodes($_->[1]))[0]->textContent } @parts;

		push(@results, Travel::Status::DE::VRR::Result->new(

		my ( $time, $platform, $line, $dest )

		  = map { ( $tr->findnodes( $_->[1] ) )[0]->textContent } @parts;

		push(

			@results,

			Travel::Status::DE::VRR::Result->new(

				time        => $time,

				platform    => $platform,

				line        => $line,

				destination => $dest,

		));

			)

		);

	}



	return @results;