Commit 33ce867b authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

csv2json, json2json: Perform consistency checks

parent 00479d5f

README.md

+3 −3
Original line number Diff line number Diff line
@@ -73,9 +73,9 @@ located in `share/stations.json`. There are two recommended editing methods. 
Automatic method, e.g. to incorporate changes from Open Data sources:



* modify stations.json with a script in any JSON-aware language you like

* run ./json2json in the share diretcory. This transforms stations.json into

  its canonical format, which simplifies tracking of changes and reduces diff

  size

* run `./json2json` in the share diretcory. This performs consistency checks and

  transforms stations.json into its canonical format, which simplifies tracking

  of changes and reduces diff size



Manual method:

share/csv2json

+2 −2
Original line number Diff line number Diff line
@@ -50,8 +50,8 @@ for my $line (@csv_lines) { 


my $have_duplicates = 0;

my @names           = map { $_->{name} } @stations;

my @ds100           = map { $_->{ds100} } @stations;

my @uic_ids         = map { $_->{uic} } @stations;

my @ds100           = map { $_->{ds100} } sort { $a->{ds100} cmp $b->{ds100} } @stations;

my @uic_ids         = map { $_->{uic} } sort { $a->{uic} <=> $b->{uic} } @stations;



for my $i ( 1 .. $#names ) {

	if ( $names[ $i - 1 ] eq $names[$i] ) {

share/json2json

+30 −0
Original line number Diff line number Diff line
@@ -10,5 +10,35 @@ use JSON; 
my $json_str = read_file('stations.json');

my $stations = JSON->new->utf8->decode($json_str);

@{$stations} = sort { $a->{name} cmp $b->{name} } @{$stations};



my $have_duplicates = 0;

my @names           = map { $_->{name} } @{$stations};

my @ds100           = map { $_->{ds100} } sort { $a->{ds100} cmp $b->{ds100} } @{$stations};

my @uic_ids         = map { $_->{uic} } sort { $a->{uic} <=> $b->{uic} } @{$stations};



for my $i ( 1 .. $#names ) {

	if ( $names[ $i - 1 ] eq $names[$i] ) {

		say "Duplicate station name: $names[$i]";

		$have_duplicates = 1;

	}

}

for my $i ( 1 .. $#ds100 ) {

	if ( $ds100[ $i - 1 ] eq $ds100[$i] ) {

		say "Duplicate DS100 code: $ds100[$i]";

		$have_duplicates = 1;

	}

}

for my $i ( 1 .. $#uic_ids ) {

	if ( $uic_ids[ $i - 1 ] == $uic_ids[$i] ) {

		say "Duplicate UIC ID: $uic_ids[$i]";

		$have_duplicates = 1;

	}

}



if ($have_duplicates) {

	say "Thank you for your contribution.";

	say "Please remove duplicate entries before opening a pull request.";

}



my $json_out = JSON->new->utf8->canonical->pretty->encode($stations);

write_file( 'stations.json', $json_out );