Unverified Commit 05924f2c authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

Login: return HTTP 400 on invalid password or unconfirmed account

parent e14966c4

lib/Travelynx/Controller/Account.pm

+10 −2
Original line number Diff line number Diff line
@@ -260,10 +260,18 @@ sub do_login { 
		else {

			my $data = $self->users->get_login_data( name => $user );

			if ( $data and $data->{status} == 0 ) {

				$self->render( 'login', invalid => 'confirmation' );

				$self->render(

					'login',

					status  => 400,

					invalid => 'confirmation'

				);

			}

			else {

				$self->render( 'login', invalid => 'credentials' );

				$self->render(

					'login',

					status  => 400,

					invalid => 'credentials'

				);

			}

		}

	}

t/02-registration.t

+2 −2
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ $t->post_ok( 
		password   => 'foofoofoo',

	}

);

$t->status_is(200)->content_like(qr{nicht freigeschaltet});

$t->status_is(400)->content_like(qr{nicht freigeschaltet});



my $res = $t->app->pg->db->select( 'users', ['id'], { name => 'someone' } );

my $uid = $res->hash->{id};
@@ -108,7 +108,7 @@ $t->post_ok( 
		password   => 'definitely invalid',

	}

);

$t->status_is(200)->content_like(qr{falsches Passwort});

$t->status_is(400)->content_like(qr{falsches Passwort});



# Successful login

$t->post_ok(