Unverified Commit 3dcb6e16 authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

Revert "/journey/edit: datetime inputs" 

This reverts commit 02a6b907.

DateTime inputs on the web are absolutely horribly broken as soon es they use
sub-minute accuracy (i.e., seconds). Switch journey edits back to %d.%m.%Y
%H:%M(:%S) to restore proper editing support. /journey/add and /checkin/add
retain their datetime pickers and will not support sub-minute accuracy.

Closes #272
parent 080b8666

lib/Travelynx/Controller/Traveling.pm

+4 −4
Original line number Diff line number Diff line
@@ -2379,12 +2379,12 @@ sub edit_journey { 


	if ( $self->param('action') and $self->param('action') eq 'save' ) {

		my $parser_sec = DateTime::Format::Strptime->new(

			pattern   => '%FT%H:%M:%S',

			pattern   => '%d.%m.%Y %H:%M:%S',

			locale    => 'de_DE',

			time_zone => 'Europe/Berlin'

		);

		my $parser_min = DateTime::Format::Strptime->new(

			pattern   => '%FT%H:%M',

			pattern   => '%d.%m.%Y %H:%M',

			locale    => 'de_DE',

			time_zone => 'Europe/Berlin'

		);
@@ -2489,10 +2489,10 @@ sub edit_journey { 
		if ( $journey->{$key} and $journey->{$key}->epoch ) {

			if ( $journey->{$key}->second ) {

				$self->param(

					$key => $journey->{$key}->strftime('%FT%H:%M:%S') );

					$key => $journey->{$key}->strftime('%d.%m.%Y %H:%M:%S') );

			}

			else {

				$self->param( $key => $journey->{$key}->strftime('%FT%H:%M') );

				$self->param( $key => $journey->{$key}->strftime('%d.%m.%Y %H:%M') );

			}

		}

	}

templates/edit_journey.html.ep

+4 −4
Original line number Diff line number Diff line
@@ -69,13 +69,13 @@ 
					<tr>

						<th scope="row">Geplante Abfahrt</th>

						<td class="input-field">

							%= datetime_field 'sched_departure', id => 'sched_departure', class => 'validate', required => undef

							%= text_field 'sched_departure', id => 'sched_departure', class => 'validate', required => undef, pattern => '[0-9][0-9]?[.][0-9][0-9]?[.][0-9][0-9][0-9][0-9] +[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?'

						</td>

					</tr>

					<tr>

						<th scope="row">Tatsächliche Abfahrt</th>

						<td class="input-field">

							%= datetime_field 'rt_departure', id => 'real_departure', class => 'validate'

							%= text_field 'rt_departure', id => 'real_departure', class => 'validate', pattern => '[0-9][0-9]?[.][0-9][0-9]?[.][0-9][0-9][0-9][0-9] +[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?'

						</td>

					</tr>

					<tr>
@@ -87,13 +87,13 @@ 
					<tr>

						<th scope="row">Geplante Ankunft</th>

						<td class="input-field">

							%= datetime_field 'sched_arrival', id => 'sched_arrival', class => 'validate', required => undef

							%= text_field 'sched_arrival', id => 'sched_arrival', class => 'validate', required => undef, pattern => '[0-9][0-9]?[.][0-9][0-9]?[.][0-9][0-9][0-9][0-9] +[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?'

						</td>

					</tr>

					<tr>

						<th scope="row">Tatsächliche Ankunft</th>

						<td class="input-field">

							%= datetime_field 'rt_arrival', id => 'real_arrival', class => 'validate'

							%= text_field 'rt_arrival', id => 'real_arrival', class => 'validate', pattern => '[0-9][0-9]?[.][0-9][0-9]?[.][0-9][0-9][0-9][0-9] +[0-9][0-9]:[0-9][0-9](:[0-9][0-9])?'

						</td>

					</tr>

					<tr>