Traveling: document why we're returning HTTP 200 on error (a083884d) · Commits · derf / travelynx

lib/Travelynx/Controller/Traveling.pm

+8 −2

Original line number	Diff line number	Diff line
		@@ -630,6 +630,9 @@ sub geolocation {
		error => $err,
		},

		# The frontend JavaScript does not have an XHR error handler yet
		# (and if it did, I do not know whether it would have access to our JSON body).
		# So, for now, we do the bad thing™ and return HTTP 200 even though the request to the backend was not successful.
		# status => 502,
		);
		}
		@@ -676,6 +679,7 @@ sub geolocation {
		error => $err,
		},

		# See above
		# status => 502
		);
		}
		@@ -729,6 +733,7 @@ sub geolocation {
		error => $err,
		},

		# See above
		#status => 502
		);
		}
		@@ -780,6 +785,7 @@ sub geolocation {
		error => $err,
		},

		# See above
		#status => 502
		);
		}