Skip to content
Snippets Groups Projects
  • Birte Kristina Friesel's avatar
    eb6566cf
    feh_parse_options_from_string: allocate argv list on stack · eb6566cf
    Birte Kristina Friesel authored
    This fixes a really weird bug where continued theme definitions containing
    just one option/value pair caused feh to mis-parse parts of the following
    line.
    
    Apparently, subsequent realloc calls mixed with strdups in another function
    caused parts of the list (argv) content to be overwritten by the content of
    the list pointer itself. I wasn't able to find out the exact causes /
    conditions.
    eb6566cf
    History
    feh_parse_options_from_string: allocate argv list on stack
    Birte Kristina Friesel authored
    This fixes a really weird bug where continued theme definitions containing
    just one option/value pair caused feh to mis-parse parts of the following
    line.
    
    Apparently, subsequent realloc calls mixed with strdups in another function
    caused parts of the list (argv) content to be overwritten by the content of
    the list pointer itself. I wasn't able to find out the exact causes /
    conditions.