Skip to content
Snippets Groups Projects
  • Birte Kristina Friesel's avatar
    d473ac13
    free accompanying EXIF data when freeing an image · d473ac13
    Birte Kristina Friesel authored
    This fixes two memory bugs that only manifest with exif=1 and long-running
    slideshows.
    
    * when feh loads an image, it writes exif data to file->ed. Previously, this
      data was never free'd, causing a memory leak on subsequent loads of the same
      file.
    * As file->ed is never free'd, the accumulated EXIF data consumes a significant
      amount of memory over time. with slideshow-delay = 10 and two days of
      runtime, feh may exceed 1 GB of memory usage. If the slideshow is so large
      that feh does not encounter the same image twice in this time, this is not
      detected as a memory leak, as each EXIF data chunk is referenced from the
      filelist.
    
    See <https://github.com/derf/feh/issues/553> for details.
    
    Closes #553
    d473ac13
    History
    free accompanying EXIF data when freeing an image
    Birte Kristina Friesel authored
    This fixes two memory bugs that only manifest with exif=1 and long-running
    slideshows.
    
    * when feh loads an image, it writes exif data to file->ed. Previously, this
      data was never free'd, causing a memory leak on subsequent loads of the same
      file.
    * As file->ed is never free'd, the accumulated EXIF data consumes a significant
      amount of memory over time. with slideshow-delay = 10 and two days of
      runtime, feh may exceed 1 GB of memory usage. If the slideshow is so large
      that feh does not encounter the same image twice in this time, this is not
      detected as a memory leak, as each EXIF data chunk is referenced from the
      filelist.
    
    See <https://github.com/derf/feh/issues/553> for details.
    
    Closes #553