Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
feh
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
derf
feh
Commits
55ef7ccc
Commit
55ef7ccc
authored
14 years ago
by
Birte Kristina Friesel
Browse files
Options
Downloads
Patches
Plain Diff
Disable filelist saving from thumbnail mode (buggy and probably not useful)
parent
1662b73a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
ChangeLog
+3
-0
3 additions, 0 deletions
ChangeLog
TODO
+2
-2
2 additions, 2 deletions
TODO
man/feh.1
+0
-2
0 additions, 2 deletions
man/feh.1
src/keyevents.c
+5
-1
5 additions, 1 deletion
src/keyevents.c
with
10 additions
and
5 deletions
ChangeLog
+
3
−
0
View file @
55ef7ccc
...
...
@@ -8,6 +8,9 @@ git HEAD
* Rename --screen-clip 0 to --no-screen-clip
* Allow multiline theme definitions (via backslash, like in the shell)
* Center the image after pressing <keypad /> or <keypad *>
* Saving the filelist from thumbnail mode caused undefined behaviour due
to handling of uninitialised memory. Since I consider this a rarely
useful action, the feature has been disabled for thumbnail mode.
Thu Jun 10 12:12:04 CEST 2010
...
...
This diff is collapsed.
Click to expand it.
TODO
+
2
−
2
View file @
55ef7ccc
...
...
@@ -24,8 +24,8 @@ A workaround (--thumb-redraw) exists, but at some point a rewrite with a
GUI-toolkit or similar (or maybe writing a completely new tool for that and
removing the feature from feh) would be due.
Saving the filelist from thumbnail mode
will access uninitialized memory if a
file was removed from the filelist
.
Saving the filelist from thumbnail mode
is not possible. I wonder if this
matters enough to be fixed
.
Maybe: Zoom mode like --bg-fill?
...
...
This diff is collapsed.
Click to expand it.
man/feh.1
+
0
−
2
View file @
55ef7ccc
...
...
@@ -753,8 +753,6 @@ available or use the builtin HTTP client
.Sh BUGS
Xinerama support does not really work on Xinerama screens != 0.
.Pp
Saving the filelist after editing it from thumbnail mode does not work.
.Pp
If you find a bug, please report it to
.Aq derf@chaosdorf.de
.
...
...
This diff is collapsed.
Click to expand it.
src/keyevents.c
+
5
−
1
View file @
55ef7ccc
...
...
@@ -336,7 +336,11 @@ void feh_event_handle_keypress(XEvent * ev)
slideshow_save_image
(
winwid
);
break
;
case
'f'
:
feh_save_filelist
();
if
((
winwid
->
type
==
WIN_TYPE_THUMBNAIL
)
||
(
winwid
->
type
==
WIN_TYPE_THUMBNAIL_VIEWER
))
weprintf
(
"Filelist saving is not supported in thumbnail mode
\n
"
);
else
feh_save_filelist
();
break
;
case
'w'
:
winwidget_size_to_image
(
winwid
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment