Commit 55ef7ccc authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

Disable filelist saving from thumbnail mode (buggy and probably not useful)

parent 1662b73a

ChangeLog

+3 −0
Original line number Diff line number Diff line
@@ -8,6 +8,9 @@ git HEAD 
    * Rename --screen-clip 0 to --no-screen-clip

    * Allow multiline theme definitions (via backslash, like in the shell)

    * Center the image after pressing <keypad /> or <keypad *>

    * Saving the filelist from thumbnail mode caused undefined behaviour due

      to handling of uninitialised memory. Since I consider this a rarely

      useful action, the feature has been disabled for thumbnail mode.



Thu Jun 10 12:12:04 CEST 2010

TODO

+2 −2
Original line number Diff line number Diff line
@@ -24,8 +24,8 @@ A workaround (--thumb-redraw) exists, but at some point a rewrite with a 
GUI-toolkit or similar (or maybe writing a completely new tool for that and

removing the feature from feh) would be due.



Saving the filelist from thumbnail mode will access uninitialized memory if a

file was removed from the filelist.

Saving the filelist from thumbnail mode is not possible. I wonder if this

matters enough to be fixed.



Maybe: Zoom mode like --bg-fill?

man/feh.1

+0 −2
Original line number Diff line number Diff line
@@ -753,8 +753,6 @@ available or use the builtin HTTP client 
.Sh BUGS

Xinerama support does not really work on Xinerama screens != 0.

.Pp

Saving the filelist after editing it from thumbnail mode does not work.

.Pp

If you find a bug, please report it to

.Aq derf@chaosdorf.de

.

src/keyevents.c

+5 −1
Original line number Diff line number Diff line
@@ -336,6 +336,10 @@ void feh_event_handle_keypress(XEvent * ev) 
		slideshow_save_image(winwid);

		break;

	case 'f':

		if ((winwid->type == WIN_TYPE_THUMBNAIL)

				|| (winwid->type == WIN_TYPE_THUMBNAIL_VIEWER))

			weprintf("Filelist saving is not supported in thumbnail mode\n");

		else

			feh_save_filelist();

		break;

	case 'w':