Commit ae1de0d8 authored by Birte Kristina Friesel's avatar Birte Kristina Friesel
Browse files

slideshow.c: save_image: Fix handling of capital file endings (closes #51) 

gib_imlib_save_image_with_error_return was used, but it tries to set the Imlib
image format by examining the filename to save to.  However, it only supports
lowercase file endings (as in .jpg) and breaks with others (like .JPG).

Since giblib is unmaintained, for now the fix is only used here.
parent 70c2ff5c

AUTHORS

+3 −1
Original line number Diff line number Diff line
@@ -44,6 +44,9 @@ JC <jcm314@yahoo.com> 
Ulrich Spoerlein <q@uni.de>

    - fullscreen image count display



Yu-Jie Lin

    - Various patches



Daniel Friesel <derf@finalrewind.org>

    - Maintenance since 2010
@@ -58,4 +61,3 @@ The Rasterman <raster@rasterman.com> 
    - Imlib2, initial zooming code example. Enlightenment.

Stephen Levine

    - Great help debugging under E17

ChangeLog

+2 −0
Original line number Diff line number Diff line
@@ -12,6 +12,8 @@ git HEAD 
      <https://github.com/derf/feh/issues/30>

    * New actions: lossless flip (key _) and mirror (key |)

      <https://github.com/derf/feh/issues/53>

    * Fix save_image key for *.JPG and similar filenames

      <https://github.com/derf/feh/issues/51>



Mon, 04 Jul 2011 14:46:36 +0200  Daniel Friesel <derf@finalrewind.org>

src/slideshow.c

+8 −1
Original line number Diff line number Diff line
@@ -472,7 +472,14 @@ void slideshow_save_image(winwidget win) 
	if (!opt.quiet)

		printf("saving image to filename '%s'\n", tmpname);



	gib_imlib_save_image_with_error_return(win->im, tmpname, &err);

	/* XXX gib_imlib_save_image_with_error_return breaks with *.XXX and

	 * similar because it tries to set the image format, which only works

	 * with .xxx .

	 * So we leave that part out.

	 */

	imlib_context_set_image(win->im);

	imlib_save_image_with_error_return(tmpname, &err);



	if (err)

		im_weprintf(win, "Can't save image %s:", tmpname);