Commit bdee6af0 authored by Tobias Stoeckmann's avatar Tobias Stoeckmann
Browse files

Avoid out of boundary read on empty/broken file. 



If ereadfile encounters an empty file or the file could not be read, an
out ouf boundary read (and possible write) occurs. Always check the
return value of fread to be > 0 before processing the result buffer.

Signed-off-by: default avatarTobias Stoeckmann <tobias@stoeckmann.org>
parent a5e60401

src/utils.c

+2 −2
Original line number Diff line number Diff line
@@ -183,14 +183,14 @@ char *ereadfile(char *path) 
{

	char buffer[4096];

	FILE *fp;

	int count;

	size_t count;



	fp = fopen(path, "r");

	if (!fp)

		return NULL;



	count = fread(buffer, sizeof(char), sizeof(buffer) - 1, fp);

	if (buffer[count - 1] == '\n')

	if (count > 0 && buffer[count - 1] == '\n')

		buffer[count - 1] = '\0';

	else

		buffer[count] = '\0';