- Mar 26, 2020
-
-
c99pedant authored
Building feh 3.3 on CentOS 7 x86_64 warns `curl_quit_function` in `imlib.c` is unused: ``` cc -g -O2 -Wall -Wextra -pedantic -std=c11 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -DHAVE_LIBCURL -DHAVE_VERSCMP -DHAVE_LIBXINERAMA -DHAVE_LIBEXIF -DPREFIX=\"/usr/local\" -DPACKAGE=\"feh\" -DVERSION=\"3.3\" -c -o imlib.o imlib.c imlib.c:545:12: warning: ‘curl_quit_function’ defined but not used [-Wunused-function] static int curl_quit_function(void *clientp, curl_off_t dltotal, curl_off_t dlnow, curl_off_t ultotal, curl_off_t ulnow) ^ ``` The `curl_quit_function` code was added in response to pull [#435](https://github.com/derf/feh/pull/435) In issue [#485](https://github.com/derf/feh/issues/485) a fellow CentOS 7 user had an error building feh because CentOS 7 is locked into an old version of libcurl. In the fix, a version guard was wrapped around the `curl_easy_setopt` call, but the rest of the code was unchanged. Since I don't want to maintain a local build of libcurl, I looked at the curl docs and noticed there is an older callback which serves the same purpose: https://curl.haxx.se/libcurl/c/CURLOPT_PROGRESSFUNCTION.html The difference between `PROGRESS` and `XFERINFO` is the callback's argument types, with `PROGRESS` using `double` and `XFERINFO` using `curl_off_t`: https://curl.haxx.se/libcurl/c/CURLOPT_XFERINFOFUNCTION.html The callback's return value logic and use of `CURLOPT_NOPROGRESS` is the same. For context, the latest libcurl RPM I'm getting from yum updates is `libcurl-7.29.0-54.el7_7.2.x86_64`. The "stable" versions of other distros may encounter similar issues. The CentOS 7 "End of Life" date is 2024-06-30 so you should hear the end of this by then, at least from us pesky CentOS users.
-
- Jan 24, 2020
-
-
Ignacio Losiggio authored
-
- Nov 07, 2019
-
-
Daniel Friesel authored
Closes #485
-
- Oct 30, 2019
-
-
Ben Boeckel authored
This can happen with images that have ridiculous dimensions.
-
- Oct 11, 2019
-
-
Olof-Joachim Frahm authored
-
- Jul 22, 2019
-
-
Birte Kristina Friesel authored
This ensures that X11 layout or other changes do not affect the .fehbg contents, which are meant to only be updated when a --bg-option is used manually. Closes #482
-
- Jul 12, 2019
-
-
Tobias Stoeckmann authored
When setting wallpapers without --no-fehbg option, a ~/.fehbg file is created. This file is set to be an executable for later re-use. Calling stat() without checking the return value can lead to issues. If the call fails, then s.st_mode is undefined and excessive permissions could be set to .fehbg, at worst even setuid/setgid bits for a world writable file. While adjusting this, I changed the code to use fstat() and fchmod() to avoid a further -- but very unlikely -- issue: race condition in form of TOCTOU. If the file ~/.fehsetbg is replaced by a symlink right before the chmod call, then a different file would be set executable + the default mode of the (newly created) file. I don't expect this to be a real world issue but changed this part "while at it" anyway for more robust code and a good example on how to handle files. Signed-off-by:
Tobias Stoeckmann <tobias@stoeckmann.org>
-
- Jul 08, 2019
-
-
Birte Kristina Friesel authored
That part slipped through while reviewing the PR...
-
- Apr 18, 2019
-
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
- Apr 12, 2019
-
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
- Apr 05, 2019
-
-
Birte Kristina Friesel authored
Closes #463
-
- Mar 26, 2019
-
-
Birte Kristina Friesel authored
-
- Mar 15, 2019
-
-
Elaina Martineau authored
-
- Mar 14, 2019
-
-
Elaina Martineau authored
-
- Feb 14, 2019
-
-
Birte Kristina Friesel authored
-
- Feb 11, 2019
-
-
Birte Kristina Friesel authored
Otherwise, several --info switches will not properly override each other
-
Birte Kristina Friesel authored
This fixes "feh -D -1 -D 1" and similar starting the slideshow in paused mode even though the last -D option specifies autostart.
- Feb 08, 2019
-
-
Birte Kristina Friesel authored
Closes #456 Note that --randomize and directory names are not saved in fehbg. It only contains the command line needed to recreate the wallpaper setup which resulted from its invocation, i.e., after randomization etc. have been applied. This is intentional.
-
- Feb 01, 2019
-
-
Birte Kristina Friesel authored
closes #458
-
- Jan 21, 2019
-
-
guraga authored
Use "extern volatile" instead of "volatile extern" to avoid "gcc" warning "'extern' is not at beginning of declaration [-Wold-style-declaration]".
-
- Dec 23, 2018
-
-
Birte Kristina Friesel authored
-
Pavel Shlyak authored
ft is already checked on line 153 so this condition is useless. Check https://github.com/derf/feh/issues/440 for more details
-
- Dec 22, 2018
-
-
Pavel Shlyak authored
It is a naive way of fixing it :) Needs attentive review
-
- Dec 04, 2018
-
-
Birte Kristina Friesel authored
sig_exit may be changed by a signal handler, so its value should always be read from RAM.
-
- Nov 29, 2018
-
-
Birte Kristina Friesel authored
See also #435
-
- Nov 23, 2018
-
-
Birte Kristina Friesel authored
-
- Nov 19, 2018
-
-
Birte Kristina Friesel authored
This changes the behaviour of "feh --start-at FILENAME" as follows: Previously, this would cause feh to load all files in the current working directory, since no files or filelists were specified on the command line. Now this is a special case: feh will extract the directory component from FILENAME, load all files in that directory, and display FILENAME. This way, it's possible to use "feh --start-at ~%f" in XDG Desktop files and browse files in feh using the prev/next keys Closes #372 Closes #420
-
- Nov 18, 2018
-
-
Birte Kristina Friesel authored
This more closely resembles the expected behaviour of --start-at, but may lead to mismatches if several files in the filelist have the same basename. Closes #206 Related to #372 and #420
-
Birte Kristina Friesel authored
-
- Nov 09, 2018
-
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
- Nov 08, 2018
-
-
Birte Kristina Friesel authored
This is in line with other software. save_filelist now defaults to "L".
-
- Nov 05, 2018
-
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
Birte Kristina Friesel authored
-
- Nov 04, 2018
-
-
Birte Kristina Friesel authored
-