becca authored 1 year ago and derf committed 1 year ago

There's a place, under BACKGROUND SETTING, where it says to use `xrandr --listmonitor` to determine how Xinerama monitor IDs map to screens etc. This should be `xrandr --listmonitors` with an 's' at the end.

Previously, the fact that --action interacts with --(un)loadable was only
mentioned in the documentation for --action, thus posing an elevated risk for
misunderstandings.

Closes #741

Closes #733

Closes #730

A signal interrupts the blocking function calls in the main iteration, so
there is really no need to do (unsafe) heavy lifting in the signal handler.

Closes #705

a1346054 authored 2 years ago and derf committed 2 years ago

No need to use `grep -F` here

orbea authored 2 years ago and derf committed 2 years ago

These are no longer supported in upcoming clang versions.

warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]

Reference: https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240

Anthony Iliopoulos authored 2 years ago and derf committed 2 years ago

inotify_add_watch calls fail when the file is a url, since it does not
correspond to an actual on-disk path. The temporary file path fetched by
curl could be kept and monitored, but since this is unlikely to change
just avoid monitoring files opened via a url.

Closes #665

The default user agent is empty, which is not that friendly.
Closes #660

Closes #656

use libmagic to detect valid file formats

init_parse_options calls feh_prepare_filelist, which in turn calls
feh_file_info_preload if opt.preload is set. This function will load all
images in the filelist to determine their attributes, so we need to initialize
libmagic before calling init_parse_options.

Add a global `magic_t magic` and initialize it just once.

Also `feh_is_image()` now calls itself to check compressed files, saving
some duplicate code.

Writing our own magic bytes detection is prone to errors and an
everlasting catch-up-game. Let's use libmagic to get things right,
this is less code and makes things more reliable.

Building without libmagic is still possible. That will make the code
act like specifying FEH_SKIP_MAGIC=1, effectively passing everything
to imlib2.