Tobias Stoeckmann authored Jul 23, 2021 and derf committed Jul 23, 2021

The snprintf string argument should not be duplicated.
It is not needed and also not released afterwards.

Tobias Stoeckmann authored Jul 23, 2021 and derf committed Jul 23, 2021

Calling feh with an empty argument leads to out of boundary access.
This can be seen best when compiled with asan:

$ feh ""

* Fix out of boundary access

The while-loop is not finished when pos is set to EXIF_MAX_DATA.
Instead, the loop continues and therefore tries to access data outside
of the array.

This is triggered when compiled with exif=1 and asan:

$ feh --draw-exif image.jpg

* Fixed formatting

No functional change but makes previous commit easier verifiable
(independent of tab space setup).

* Call break; instead of setting pos2 to a magic value

This is in line with the following else clause

* Another cosmetic adjustment

Co-authored-by: Daniel Friesel <derf@finalrewind.org>

Fix feh_is_image for tiny (<16 byte) image files

Alistair authored Jun 09, 2021 and derf committed Jun 09, 2021

Note that Imlib2 does not support JXL images out of the box.  However, the
imlib2-jxl loader (https://github.com/alistair7/imlib2-jxl) does.

This is consistent with --scroll-step (option name) and --zoom (percentage)

"screen" and "display" are different X11 terms; we're actually talking about
"monitors"

This should help answer questions such as #605 in the future

parazyd authored Mar 10, 2021 and derf committed Mar 10, 2021

Both of these protocols are supported in latest curl.

Signed-off-by: parazyd <parazyd@dyne.org>

This makes --(auto-)reload use the directory specified at --start-at
instead of the current working directory. Closes #597

* fixed for simpler parenthesis matching

* absolute file path for .fehbg, moved script creation into helper function

* Removed unused variable.

* added early exit condition as per Ferada's suggestion

* Added enum for options to improve readability

* migrated options to enum.

* added support for zoom specification through options

* added man entry for zoom-rate

* added help entry for zoom-rate commands

* updated man to have warnings about strange values for zoom options

* fix memory leak (free exec_absolute_path)

* added detection for path vs env PATH launch for use in .fehbg script gen.

* Added enum for options to improve readability

* migrated options to enum.

* added support for zoom specification through options

* added man entry for zoom-rate

* added help entry for zoom-rate commands

* updated man to have warnings about strange values for zoom options

* Update help.raw

removed zoom-in/out

* removed zoom-in/out from options

* updated man/help entry to remove in/out zoom specification

* sanitize --zoom-rate in options parser; use a single variable for storing it

Co-authored-by: Daniel Friesel <derf@finalrewind.org>

This fixes Ctrl+key causing unintended behaviour. Closes #596

Fix some warnings from `gcc`.

Closes #595

.fehbg now stores the full path to the feh binary when it was run using a relative path (i.e., not from $PATH)

Closes #584

feh is C code, _XFUNCPROTO(BEGIN|END) are only needed for C++ applications.

Closes #584